Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: completion event on content consumption #38

Merged
merged 1 commit into from
Sep 13, 2024
Merged

add: completion event on content consumption #38

merged 1 commit into from
Sep 13, 2024

Conversation

ichintanjoshi
Copy link
Contributor

Description
This PR adds a check on event of "consumed".
These events are fired when content of "accordion" is used.

Reference Screenshot
image

Reasoning

  • Accordion is listed at the top of example and downloads section of h5p site.
  • Accordion type content was not being marked as complete
  • With this change it'll be marked as complete upon viewing it

ziafazal
ziafazal approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ziafazal ziafazal merged commit 1cbef60 into edly-io:master Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziafazal ziafazal ziafazal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichintanjoshi @ziafazal